This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/191/2/openbsc/src/gprs/sgsn_main.c File openbsc/src/gprs/sgsn_main.c: Line 292: .enabled = 1, .loglevel = LOGL_DEBUG, > not sure if DEBUG is such a suitable default, we should fix that in other / while the 3G stuff is still unstable, I'd personally prefer having DEBUG by default, because "normal users" will be practically us developing on it. But I fully agree in principle. Let's move away from DEBUG soon-ish. https://gerrit.osmocom.org/#/c/191/2/openbsc/src/libcommon/debug.c File openbsc/src/libcommon/debug.c: Line 173: [DSUA] = { > Why do we have to declare it both in libcommon and in sgsn? Because libcomm hmm, interesting point... actually libcommon *is* linked to osmo-sgsn. But sgsn_main.c defines an own gprs_loginfo with own gprs_categories. Actually this applies to pretty much all of the D* in gprs_categories in sgsn_main.c. I'm not sure whether osmo-sgsn wants to explicitly have less categories than libcommon provides in its default_categories. (BTW we also define DSUA in osmo-iuh in hnbgw.h and hnbgw.c and libosmo-sccp in sua.c) In conclusion, If this needs to change I think that that should happen outside of the IuPS topic and along with all the other D* in sgsn_main.c -- To view, visit https://gerrit.osmocom.org/191 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4a3a8189564345700ea4825983ab39a8411227f4 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: daniel <dwillmann at sysmocom.de> Gerrit-HasComments: Yes