[PATCH] osmo-pcu[master]: Extend BTS <-> PCU protocol with measurement

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Jul 29 15:53:29 UTC 2016


Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/624

to look at the new patch set (#2).

Extend BTS <-> PCU protocol with measurement

Note: this increases the version of BTS <-> PCU protocol and thus
requires corresponding change in BTS.

Change-Id: Ide0e29b668ee38516605c1763fda85e87e867813
Related: OS#1616
---
M src/pcu_l1_if.cpp
M src/pcuif_proto.h
2 files changed, 13 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/24/624/2

diff --git a/src/pcu_l1_if.cpp b/src/pcu_l1_if.cpp
index 36cf9ad..1434213 100644
--- a/src/pcu_l1_if.cpp
+++ b/src/pcu_l1_if.cpp
@@ -214,7 +214,15 @@
 	int rc;
 	pcu_l1_meas meas;
 	meas.set_rssi(data_ind->rssi);
-
+#ifndef ENABLE_DIRECT_PHY
+	/* convert BER to % value */
+	meas.set_ber(data_ind->ber10k / 100);
+	meas.set_bto(data_ind->ta_offs_qbits);
+	meas.set_link_qual(data_ind->lqual_cb / 10);
+	LOGP(DL1IF, LOGL_DEBUG, "Data indication with raw measurements "
+	     "received: BER10k = %d, BTO = %d, Q = %d\n", data_ind->ber10k,
+	     data_ind->ta_offs_qbits, data_ind->lqual_cb);
+#endif
 	LOGP(DL1IF, LOGL_DEBUG, "Data indication received: sapi=%d arfcn=%d "
 		"block=%d data=%s\n", data_ind->sapi,
 		data_ind->arfcn, data_ind->block_nr,
diff --git a/src/pcuif_proto.h b/src/pcuif_proto.h
index 9d740ac..d320380 100644
--- a/src/pcuif_proto.h
+++ b/src/pcuif_proto.h
@@ -1,7 +1,7 @@
 #ifndef _PCUIF_PROTO_H
 #define _PCUIF_PROTO_H
 
-#define PCU_IF_VERSION		0x05
+#define PCU_IF_VERSION		0x06
 
 /* msg_type */
 #define PCU_IF_MSG_DATA_REQ	0x00	/* send data to given channel */
@@ -50,6 +50,9 @@
 	uint8_t		ts_nr;
 	uint8_t		block_nr;
 	int8_t		rssi;
+	uint16_t ber10k;	/*!< \brief BER in units of 0.01% */
+	int16_t ta_offs_qbits;	/* !< \brief Burst TA Offset in quarter bits */
+	int16_t lqual_cb;	/* !< \brief Link quality in centiBel */
 } __attribute__ ((packed));
 
 struct gsm_pcu_if_rts_req {

-- 
To view, visit https://gerrit.osmocom.org/624
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ide0e29b668ee38516605c1763fda85e87e867813
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list