libosmocore[master]: Extend L1SAP with Measurements

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jul 28 17:02:42 UTC 2016


Patch Set 1: Code-Review-2

(1 comment)

https://gerrit.osmocom.org/#/c/622/1/include/osmocom/gsm/l1sap.h
File include/osmocom/gsm/l1sap.h:

Line 73: 	uint8_t ber;		/* !< \brief Bit Error Rate in % */
see similar comment regarding the PCU interface.  Please either look at existing code dealing with BER and quality values as integer, or familiarize yourself with the ranges of the parameters and then decide on the coding/type.


-- 
To view, visit https://gerrit.osmocom.org/622
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2b127eb1856c4cd1bc46490a89592a595f1ee86b
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list