[MERGED] libosmocore[master]: Mark input string to osmo_talloc_replace_string() as const

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jul 28 06:09:34 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: Mark input string to osmo_talloc_replace_string() as const
......................................................................


Mark input string to osmo_talloc_replace_string() as const

This allows us to pass in strings that are 'const', which for the
source of a copy should be the normal/regular case anyway.

Change-Id: Icee6a5f88babd3a4e30bf0886f0f8d3b865d80ce
---
M include/osmocom/core/utils.h
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/include/osmocom/core/utils.h b/include/osmocom/core/utils.h
index 476e492..01d5520 100644
--- a/include/osmocom/core/utils.h
+++ b/include/osmocom/core/utils.h
@@ -71,7 +71,7 @@
  * \param[in] ctx Talloc context to use for allocation
  * \param[out] dst pointer to string, will be updated with ptr to new string
  * \param[in] newstr String that will be copieed to newly allocated string */
-static inline void osmo_talloc_replace_string(void *ctx, char **dst, char *newstr)
+static inline void osmo_talloc_replace_string(void *ctx, char **dst, const char *newstr)
 {
 	if (*dst)
 		talloc_free(*dst);

-- 
To view, visit https://gerrit.osmocom.org/621
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icee6a5f88babd3a4e30bf0886f0f8d3b865d80ce
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list