[PATCH] openbsc[master]: debug log: fix line endings for abis_rsl_rx_rll logging

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Tue Jul 26 17:46:43 UTC 2016


Review at  https://gerrit.osmocom.org/613

debug log: fix line endings for abis_rsl_rx_rll logging

This function outputs a debug log without line ending, which should be
completed by a subsequent DEBUGPC(), so complete the started log line where
missing in three of the switch cases.

The three cases do print another log message, but since these don't start on a
new line when RLL is in debug level, the log output for these is hard(er) to
read without this patch.

Change-Id: I355647e77e1b2d8e75ae1a167fe87a507a38d82d
---
M openbsc/src/libbsc/abis_rsl.c
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/13/613/1

diff --git a/openbsc/src/libbsc/abis_rsl.c b/openbsc/src/libbsc/abis_rsl.c
index a0faf25..6ddb088 100644
--- a/openbsc/src/libbsc/abis_rsl.c
+++ b/openbsc/src/libbsc/abis_rsl.c
@@ -1773,13 +1773,16 @@
 		rsl_handle_release(msg->lchan);
 		break;
 	case RSL_MT_ERROR_IND:
+		DEBUGPC(DRLL, "ERROR INDICATION\n");
 		rc = rsl_rx_rll_err_ind(msg);
 		break;
 	case RSL_MT_UNIT_DATA_IND:
+		DEBUGPC(DRLL, "UNIT DATA INDICATION\n");
 		LOGP(DRLL, LOGL_NOTICE, "unimplemented Abis RLL message "
 			"type 0x%02x\n", rllh->c.msg_type);
 		break;
 	default:
+		DEBUGPC(DRLL, "UNKNOWN\n");
 		LOGP(DRLL, LOGL_NOTICE, "unknown Abis RLL message "
 			"type 0x%02x\n", rllh->c.msg_type);
 	}

-- 
To view, visit https://gerrit.osmocom.org/613
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I355647e77e1b2d8e75ae1a167fe87a507a38d82d
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list