This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgPatch Set 7: (4 comments) https://gerrit.osmocom.org/#/c/537/6/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 445: block->block_info.data_len = block->len; > How is that replaced now? rlc_data and block->block pointed/aliased the sam This part of the code will be hit when second segment has already been received. This memmove is removed and the change is made at the place where second segment is received before first segment(Please see the latest patch set). When second segment is received before first segment. Earlier the second segment was copied to 0th position. So when first segment is received there was a memmove necessary. But now. When second segment is received first it is copied to the 0th + len. so that memmove is not required when first segment is received. https://gerrit.osmocom.org/#/c/537/7/src/tbf_ul.cpp File src/tbf_ul.cpp: Line 448: return EGPRS_RESEG_DEFAULT; > Sorry. I was replying about the 0x03 vs. 0x04 and now look more carefully a Ok. I see your point. I will update the same. https://gerrit.osmocom.org/#/c/537/7/tests/tbf/TbfTest.cpp File tests/tbf/TbfTest.cpp: Line 754: EGPRS_RESEG_DEFAULT); > Check the assembled data here? Can you do that? And reset the data again? As the assembled data is random cannot be checked here. and intention of this test is only to validate the assembly status. The validation of assembled data is done at the end of this function where BSN3, BSN4, BSN5 data is compared with memcmp function. I can only validate the assembled mcs here along with len. Line 1020: OSMO_ASSERT(ul_tbf->m_rlc.block(5)->cs_last == > check the MCS once by hand as well. Maybe when you have block->len == 74? Ok. I will do the same -- To view, visit https://gerrit.osmocom.org/537 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I39ca53218b6e0982abc2ab9c703c24c8bf0a09c0 Gerrit-PatchSet: 7 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes