osmo-pcu[master]: Add test case for decompression of compressed bitmap

[pravin]

Patch Set 3:

> Yes, but see my mailinglist post. The test from libosmocore needs
 > to be copied. The tree based decoder should not have less test
 > coverage than the one in libosmocore.

The vectors used in libosmocore is copied as 5th and 6th elements of array of test_data in TbfTest.cpp
In bitcomp_test.c  test vectors in below lines ,
	bitvec_set_uint(&bv, 0xDE887565, 32);
	bitvec_set_uint(&bv, 4, 3);
are equivalent to below line  in TbfTest.cpp
{ (int8_t)32, (uint8_t)0, {0xde, 0x88, 0x75, 0x65, 0x80}, {0x37, 0x47, 0x81, 0xf0}, (int)28},
and 
test vector in below line of bitcomp_test.c 
 printf(" [%d]\nExpected:\n1 11011101 01000001 00 [18]\n", bv.cur_bit);

is equivalent to below line in TbfTest.cpp
	{ (int8_t)18, (uint8_t)1, {0xdd, 0x41, 0x00}, {0xff, 0xff, 0xff, 0xff, 0xff, 0xff,	0xff, 0xff, 0xff, 0xff, 0x00, 0x00}, (int)90, 1},
I do not see any other vectors in the test mentioned in libosmocore with respect to decoding.

 > 3. Add separate test for the decoding, take test data and results
 > from libosmocore

 As mentioned above, test data and results are already taken from libosmocore. Separate test "test_EPDAN_decode_tree" is added for testing decoding in TbfTest.cpp.
Let us know if you think we are missing some point.

-- 
To view, visit https://gerrit.osmocom.org/417
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0f26ec3d9eeace4ea8396ad5786a988fb58cf445
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: pravin <pravin.manoharan at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>
Gerrit-HasComments: No