openbsc[master]: gsm_ts2chan_nr(): use constants instead of magic numbers

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jul 25 16:09:16 UTC 2016


Patch Set 1:

> I think it's debatable how much of an improvement it is, but then I
 > don't think it's worth spending time on a debate.

Yeah. I had added the RSL_CHAN_OSMO_PDCH constant and wanted to use
it. I saw that all the other RSL_CHAN_* weren't used, so I kind of
slipped into adding all of them. I find it better to use the constants,
but there are also other places that shift cbits around instead
of using the constants ...

-- 
To view, visit https://gerrit.osmocom.org/588
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I14dceab6ac9f0d4ad852259eae643f567d0982f2
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list