[MERGED] openbsc[master]: fix: create_pdp_conf(): unset reject_cause after unknown ran...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jul 25 15:19:51 UTC 2016


Neels Hofmeyr has submitted this change and it was merged.

Change subject: fix: create_pdp_conf(): unset reject_cause after unknown ran_type
......................................................................


fix: create_pdp_conf(): unset reject_cause after unknown ran_type

f9f4387686584d4575b326ac7414138d8ba0c641 introduced a check for ran_type,
which potentially leaves reject_cause unset. Fix that.

Change-Id: I0220841ff796f949d00a1415d46b54a3eacc9493
---
M openbsc/src/gprs/sgsn_libgtp.c
1 file changed, 4 insertions(+), 0 deletions(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/src/gprs/sgsn_libgtp.c b/openbsc/src/gprs/sgsn_libgtp.c
index d138500..be7637a 100644
--- a/openbsc/src/gprs/sgsn_libgtp.c
+++ b/openbsc/src/gprs/sgsn_libgtp.c
@@ -358,6 +358,10 @@
 		return send_act_pdp_cont_acc(pctx);
 	}
 
+	LOGP(DGPRS, LOGL_ERROR, "Unknown ran_type %d\n",
+	     pctx->mm->ran_type);
+	reject_cause = GSM_CAUSE_PROTO_ERR_UNSPEC;
+
 reject:
 	/*
 	 * In case of a timeout pdp will be NULL but we have a valid pointer

-- 
To view, visit https://gerrit.osmocom.org/563
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0220841ff796f949d00a1415d46b54a3eacc9493
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list