This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgReview at https://gerrit.osmocom.org/573 cosmetic: pcu_sock.c: rename ts_is_pdch() to ts_should_be_pdch() The function checks whether to switch a TS to/from PDCH, not whether it already is PDCH. Change-Id: Ib4036445d09792636bb2f1a8a665b6b28f32e1a0 --- M src/common/pcu_sock.c 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-bts refs/changes/73/573/1 diff --git a/src/common/pcu_sock.c b/src/common/pcu_sock.c index d52cdb1..845e5bb 100644 --- a/src/common/pcu_sock.c +++ b/src/common/pcu_sock.c @@ -95,7 +95,7 @@ return msg; } -static bool ts_is_pdch(struct gsm_bts_trx_ts *ts) { +static bool ts_should_be_pdch(struct gsm_bts_trx_ts *ts) { if (ts->pchan == GSM_PCHAN_PDCH) return true; if (ts->pchan == GSM_PCHAN_TCH_F_PDCH) { @@ -225,7 +225,7 @@ for (j = 0; j < 8; j++) { ts = &trx->ts[j]; if (ts->mo.nm_state.operational == NM_OPSTATE_ENABLED - && ts_is_pdch(ts)) { + && ts_should_be_pdch(ts)) { info_ind->trx[i].pdch_mask |= (1 << j); info_ind->trx[i].tsc[j] = (ts->tsc >= 0) ? ts->tsc : bts->bsic & 7; -- To view, visit https://gerrit.osmocom.org/573 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib4036445d09792636bb2f1a8a665b6b28f32e1a0 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>