openbsc[master]: Modify SI 13 field for control_ack_type

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Jul 25 09:28:57 UTC 2016


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/546/2/openbsc/src/libbsc/bsc_vty.c
File openbsc/src/libbsc/bsc_vty.c:

Line 455: 	vty_out(vty, "  gprs control-ack-type %u%s",
> Not here. But I think LaForge's rule is to not write it if it is the defaul
Hmm, then when we have an example conf file with the default value and it gets tested by the vty tests, the default value will not be written out again and the test fails?


-- 
To view, visit https://gerrit.osmocom.org/546
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie869ac0a82055110f1e3b875e246750c4e113336
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list