osmo-pcu[master]: Handle Timing Advance IE properly

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sun Jul 24 15:18:12 UTC 2016


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/552/4/src/encoding.cpp
File src/encoding.cpp:

Line 36: static inline bool write_tai(bitvec *dest, unsigned& wp, int8_t tai)
Why should wp be a mutable reference?


https://gerrit.osmocom.org/#/c/552/4/src/tbf.cpp
File src/tbf.cpp:

Line 1067: 		bts_data()->gamma, -1, 0, is_egprs_enabled());
Why 0 as TS?


-- 
To view, visit https://gerrit.osmocom.org/552
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I786bf7fc999d401cc3d9e7f1e7a1fba953b5d458
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list