This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 2: Code-Review-1 (2 comments) The 0|1 -> true/false part is somehow confusing. If you use 0 | 1 then maybe use names? Add a test to verify that the default remains '1'? https://gerrit.osmocom.org/#/c/546/2/openbsc/src/libbsc/bsc_vty.c File openbsc/src/libbsc/bsc_vty.c: Line 455: vty_out(vty, " gprs control-ack-type %u%s", Not here. But I think LaForge's rule is to not write it if it is the default value? Line 2688: "gprs control-ack-type (0|1)", use names? -- To view, visit https://gerrit.osmocom.org/546 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie869ac0a82055110f1e3b875e246750c4e113336 Gerrit-PatchSet: 2 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes