This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
pravin gerrit-no-reply at lists.osmocom.orgPatch Set 3: > Please see the GPRS mailinglist for the path of merging the tree > based code. This change as such will not be merged to the PCU. As you suggested, 1. I have changed all malloc memory allocation to talloc. 2. Added test vectors taken from libosmocore in tbf_test.cpp. 3. Return value from the search_runlen & decompress_crbb are handled properly. 4. Invalid inputs were added in the test vector with suppression of verification. 5. Code duplication is removed in decompress_crbb. The only points that were missing are as below, and that will be corrected and submitted in next set 1. Freeing of context tall_pcu_ctx recursively frees all its children so, there is no need to call separate function to free the memory allocated for tree. 2. Same commit will be used for source and test. -- To view, visit https://gerrit.osmocom.org/417 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0f26ec3d9eeace4ea8396ad5786a988fb58cf445 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com> Gerrit-HasComments: No