osmo-pcu[master]: Add data structure for SPB in EGPRS UL

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Jul 14 13:05:00 UTC 2016


Patch Set 3:

(1 comment)

https://gerrit.osmocom.org/#/c/536/3/src/rlc.h
File src/rlc.h:

Line 58: /* This feature provides provision for MS to retransmit
Saying "This feature" is out of context here...
Maybe start with "The EGPRS resegmentation feature allows MS to..." instead?

Would it make sense to add this comment to the bottom of
the comment for egprs_rlc_ul_reseg_bsn_state? That would
also clarify the context.

(Sorry to keep you busy with details like this, but from
the perspective of a future reader, ambiguity should be
avoided.)


-- 
To view, visit https://gerrit.osmocom.org/536
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I83ccd136bb361adcfd511c57c5a9d95ed72c36c2
Gerrit-PatchSet: 3
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list