This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (1 comment) In terms of order this is blocked by getting the tree based decoder into the PCU for the PDAN handling but I wanted to comment briefly already. And please see my general comment of where to put tests (never after new code) For the commit message I would like to know under which circumstances you have seen the compression code kicking in? https://gerrit.osmocom.org/#/c/413/1/src/encoding.cpp File src/encoding.cpp: Line 573: is_compressed = 1; * Wrong indent * Is vs. try The current code checks at the end _if_ something is compressed while you now use that flag to try to compress. For the time being please introduce try_to_compress or try_compress or use_compression and only after it has been compressed set is_compressed to indicate the state. -- To view, visit https://gerrit.osmocom.org/413 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I89683e82eda6c80b7328ddb4ec2c2f55d4a687aa Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: prasadkg <Prasad.Kaup at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: prasadkg <Prasad.Kaup at radisys.com> Gerrit-HasComments: Yes