This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 3: Code-Review-1 (3 comments) I think the cs2 vs. *may_combine is a real issue. Please have a look. https://gerrit.osmocom.org/#/c/334/2/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 392: */ > I will remove it. My bad. I didn't notice that this wasn't in before. It is a valuable comment I just thought a different commit would be better. Please leave it here. https://gerrit.osmocom.org/#/c/334/3/src/tbf_dl.cpp File src/tbf_dl.cpp: Line 358: GprsCodingScheme cs2; The role of cs2 is odd. Line 423: cs2 = force_cs ? force_cs : current_cs(); this is inconsistent with the *may_combine. a couple of lines below. It looks like a bug. *may_combine is answered for a CS that is not equal to the cs we have used to generate the BSN -- To view, visit https://gerrit.osmocom.org/334 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7a845c98f2018795f0f62240f228411b0bc030c7 Gerrit-PatchSet: 3 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes