This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (5 comments) https://gerrit.osmocom.org/#/c/430/1/src/bts.cpp File src/bts.cpp: Line 488: sb = is_single_block(ra, burst, is_11bit, &ms_class, &priority); I would prefer if we always have ms_class as a well defined value here. E.g. 0 if not known. Either in is_single_block or before calling it. Line 515: ms_class, 1); ms_class might not be initialized here. Line 519: tbf = tbf_alloc_ul_tbf(&m_bts, NULL, -1, 0, 0, 1); use ms_class after it is well defined. Line 579: LOGP(DRLCMAC, LOGL_INFO, "MS requests single block " 1st Info is way too verbose here. 2nd: The log messages doesn't have a lot/enough context to be generally usable (beyond DEBUG) Line 610: "Error: GPRS 11 bit RACH not supported\n"); in this case sb==0 and ms_class is not initialzed but it will be passed to tbf_alloc_ul_tbf. -- To view, visit https://gerrit.osmocom.org/430 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I61d74a32f7764644ed86f7fdf97fa3c2f61503f7 Gerrit-PatchSet: 1 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes