libosmocore[master]: lapdm: Fix malformed Abis messages

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Tue Jul 12 05:47:33 UTC 2016


Patch Set 3:

Test is most likely failing because of:

                #warning "RSL_IE_L3_INFO 16 bit length is wrong"

if this would be a xUnit kind o framework it would be an "expected failure". Now that it is fixed the test can be corrected. But as I had pointed out there are three different places we fix that and it would be great if a testcase could be added for all them.

The testcase (+ our execution of them before accepting new patches) is kind of a warranty for your contribution. If you write a testcase you will know your feature will not break for years to come.

-- 
To view, visit https://gerrit.osmocom.org/266
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idbf43d4fdda6b2a6b4d8d15826735ce5f260ad89
Gerrit-PatchSet: 3
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Minh-Quang Nguyen <minh-quang.nguyen at nutaq.com>
Gerrit-HasComments: No



More information about the gerrit-log mailing list