[MERGED] osmo-bts[master]: cosmetic: osmo-bts-trx: add comment, fix comment typo

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Jul 9 19:50:50 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: cosmetic: osmo-bts-trx: add comment, fix comment typo
......................................................................


cosmetic: osmo-bts-trx: add comment, fix comment typo

Change-Id: Iea62bd98954d0219ba597613cea6db63f7a6b396
---
M include/osmo-bts/scheduler.h
M src/osmo-bts-trx/l1_if.c
2 files changed, 3 insertions(+), 2 deletions(-)

Approvals:
  Tom Tsou: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified
  Holger Freyther: Looks good to me, but someone else must approve



diff --git a/include/osmo-bts/scheduler.h b/include/osmo-bts/scheduler.h
index b11e6f1..090f5a5 100644
--- a/include/osmo-bts/scheduler.h
+++ b/include/osmo-bts/scheduler.h
@@ -134,10 +134,10 @@
 extern uint32_t transceiver_last_fn;
 
 
-/*! \brief Initialize the scheudler data structures */
+/*! \brief Initialize the scheduler data structures */
 int trx_sched_init(struct l1sched_trx *l1t, struct gsm_bts_trx *trx);
 
-/*! \brief De-initialize the scheudler data structures */
+/*! \brief De-initialize the scheduler data structures */
 void trx_sched_exit(struct l1sched_trx *l1t);
 
 /*! \brief Handle a PH-DATA.req from L2 down to L1 */
diff --git a/src/osmo-bts-trx/l1_if.c b/src/osmo-bts-trx/l1_if.c
index 0a3e48d..7f4b9f7 100644
--- a/src/osmo-bts-trx/l1_if.c
+++ b/src/osmo-bts-trx/l1_if.c
@@ -606,6 +606,7 @@
 					0);
 				break;
 			}
+			/* here, type == PRIM_INFO_DEACTIVATE */
 			if ((chan_nr & 0x80)) {
 				LOGP(DL1C, LOGL_ERROR, "Cannot deactivate "
 					"chan_nr 0x%02x\n", chan_nr);

-- 
To view, visit https://gerrit.osmocom.org/471
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iea62bd98954d0219ba597613cea6db63f7a6b396
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>



More information about the gerrit-log mailing list