openbsc[master]: SGSN: move cipher application to separate function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Holger Freyther gerrit-no-reply at lists.osmocom.org
Sat Jul 9 06:24:59 UTC 2016


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.osmocom.org/#/c/479/4//COMMIT_MSG
Commit Message:

Line 9: FCS-related corrections were contributed by Dieter Spaar.
"Move" and "correct" are different parts. If you correct then please highlight which parts have been corrected and why they are correct. As part of the move I didn't see the actual difference.

So please separate in move into separate function and then apply dieters fixes? Make a fix obvious and self explanatory, it is not the case here.


https://gerrit.osmocom.org/#/c/479/4/openbsc/src/gprs/gprs_gmm.c
File openbsc/src/gprs/gprs_gmm.c:

Line 1325: 		     get_value_string(gprs_msgt_gmm_names, gh->msg_type));
okay this is why the previous commit doesn't compile?


-- 
To view, visit https://gerrit.osmocom.org/479
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied74fcd971edba793b5a0958eb66707e5fa94074
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list