This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Holger Freyther gerrit-no-reply at lists.osmocom.org
Patch Set 5:
(2 comments)
https://gerrit.osmocom.org/#/c/469/5/openbsc/src/gprs/gprs_gmm.c
File openbsc/src/gprs/gprs_gmm.c:
Line 972: if (ctx->is_authenticated) {
coding style. no {}
Line 1409: gprs_llme_set_key(mmctx, mmctx->gb.llme);
"Set key" but no key is being provided. The function should be called differently. E.g. copy_key, assign_key, use_key
--
To view, visit https://gerrit.osmocom.org/469
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8a0bc907072dc19cd9535a28b5252dc0f05357cc
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes