This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.org
Patch Set 1:
(1 comment)
https://gerrit.osmocom.org/#/c/482/1/src/osmo-bts-trx/gsm0460.h
File src/osmo-bts-trx/gsm0460.h:
Line 9: struct gsm0460_egprs_dl_hdr_type1 {
> Indeed, the header definitions exist in OsmoPCU. The CPS tables are only us
actually, my comment was about the definition of the (E)GPRS headers.
The coding/puncturing scheme tables should probably also move to libosmogsm, as they want to be used from gprsdecode and other utilities, too. It might make sense to actually create something like a 'libosmo-gsm-phy' where all the gsm0503_* stuff from osmo-bts-trx goes into. Not just for the benefit of sniffing tools like gprsdecode or other burst_ind related stuff, but also in case somebody actually wants to complete the SDR hardware support for OsmocomBB. But that's not really related to this patch.
--
To view, visit https://gerrit.osmocom.org/482
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f059ae34c6f36179553cbc972f8becf8179eb55
Gerrit-PatchSet: 1
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Tom Tsou <tom at tsou.cc>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Tom Tsou <tom at tsou.cc>
Gerrit-HasComments: Yes