This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 7: Code-Review+2 (1 comment) https://gerrit.osmocom.org/#/c/460/7/openbsc/src/gprs/gprs_llc.c File openbsc/src/gprs/gprs_llc.c: Line 785: llme->iov_ui = rand(); it might be a good idea to use a less weak source of random numbers than the glibc PRNG. I beleive in we already use openssl random number genretor in other parts of the osmocom code. Maybe it's time to move that to a centralized osmo_get_random() function in libosmocore, which then has a (default) openssl backend. This can be an incremental patch, of course. -- To view, visit https://gerrit.osmocom.org/460 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8900b906693496e4e6b35be5a86937c58039ed9e Gerrit-PatchSet: 7 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes