openbsc[master]: SGSN: move cipher application to separate function

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Jul 7 12:34:55 UTC 2016


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/479/2/openbsc/src/gprs/gprs_llc.c
File openbsc/src/gprs/gprs_llc.c:

Line 349: static bool apply_gea(struct gprs_llc_lle *lle, uint16_t crypt_len, uint16_t nu,
the general custom in osmocom gsm code is to return 0 on success and negative values on error.  I would appreciate if we could continue to do so, *except* predicate-check functions like bts_is_nanobts(bts) or something like this.


-- 
To view, visit https://gerrit.osmocom.org/479
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ied74fcd971edba793b5a0958eb66707e5fa94074
Gerrit-PatchSet: 2
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list