[PATCH] libosmocore[master]: serial.c: Some ports don't support TIOCMBIS for RTS/CTS control

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Dec 23 22:01:34 UTC 2016


Review at  https://gerrit.osmocom.org/1501

serial.c: Some ports don't support TIOCMBIS for RTS/CTS control

So let's ignore the error we might get from this opreration.

Change-Id: I69dad90403355b6512c3bf4c7fd10dd1dd985f01
---
M src/serial.c
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/01/1501/1

diff --git a/src/serial.c b/src/serial.c
index 4403226..1cbd3c0 100644
--- a/src/serial.c
+++ b/src/serial.c
@@ -113,8 +113,8 @@
 	rc = ioctl(fd, TIOCMBIS, &v24);
 	if (rc < 0) {
 		dbg_perror("ioctl(TIOCMBIS)");
-		rc = -errno;
-		goto error;
+		/* some serial porst don't support this, so let's not
+		 * return an error here */
 	}
 
 	return fd;

-- 
To view, visit https://gerrit.osmocom.org/1501
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I69dad90403355b6512c3bf4c7fd10dd1dd985f01
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>



More information about the gerrit-log mailing list