[PATCH] openbsc[master]: bsc_control.py: remove unused -i option

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Fri Dec 16 13:12:33 UTC 2016


Hello Neels Hofmeyr, Harald Welte, Jenkins Builder, Holger Freyther,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1270

to look at the new patch set (#11).

bsc_control.py: remove unused -i option

This option only served to demonstrate possibility of manually selecting
<id> field in CTRL protocol. Since the transition to generic ipa module
this is no longer exposed so the option became no-op. Correspondingly
there's no need to explicitly initialize RNG - Ctrl class handl this
internally as well as random <id> generation.

Change-Id: I10cc7c069354cced2bba84fe67c69c28b8596ded
---
M openbsc/contrib/bsc_control.py
1 file changed, 0 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/70/1270/11

diff --git a/openbsc/contrib/bsc_control.py b/openbsc/contrib/bsc_control.py
index cd2ba6d..66a41eb 100755
--- a/openbsc/contrib/bsc_control.py
+++ b/openbsc/contrib/bsc_control.py
@@ -1,7 +1,6 @@
 #!/usr/bin/python
 # -*- mode: python-mode; py-indent-tabs-mode: nil -*-
 
-import random
 from optparse import OptionParser
 from ipa import Ctrl
 import socket
@@ -44,8 +43,6 @@
         return False
 
 if __name__ == '__main__':
-        random.seed()
-
         parser = OptionParser("Usage: %prog [options] var [value]")
         parser.add_option("-d", "--host", dest="host",
                           help="connect to HOST", metavar="HOST")
@@ -55,8 +52,6 @@
                           dest="cmd_get", help="perform GET operation")
         parser.add_option("-s", "--set", action="store_true",
                           dest="cmd_set", help="perform SET operation")
-        parser.add_option("-i", "--id", dest="op_id", default=random.randint(1, sys.maxint),
-                          help="set id manually", metavar="ID")
         parser.add_option("-v", "--verbose", action="store_true",
                           dest="verbose", help="be verbose", default=False)
         parser.add_option("-m", "--monitor", action="store_true",

-- 
To view, visit https://gerrit.osmocom.org/1270
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I10cc7c069354cced2bba84fe67c69c28b8596ded
Gerrit-PatchSet: 11
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list