[MERGED] osmo-pcu[master]: Fix uninitialized members in pcu_l1_meas()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Dec 16 11:56:48 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: Fix uninitialized members in pcu_l1_meas()
......................................................................


Fix uninitialized members in pcu_l1_meas()

Change-Id: I76a03c9f54be474ab9ece908ef782807d555c6ac
Fixes: Coverity CID 57952
---
M src/pcu_l1_if.h
1 file changed, 8 insertions(+), 1 deletion(-)

Approvals:
  Max: Looks good to me, but someone else must approve
  Harald Welte: Looks good to me, but someone else must approve
  Jenkins Builder: Verified
  Holger Freyther: Looks good to me, approved



diff --git a/src/pcu_l1_if.h b/src/pcu_l1_if.h
index 9ab46a8..eaa0143 100644
--- a/src/pcu_l1_if.h
+++ b/src/pcu_l1_if.h
@@ -110,7 +110,14 @@
 		have_ms_rx_qual(0),
 		have_ms_c_value(0),
 		have_ms_sign_var(0),
-		have_ms_i_level(0)
+		have_ms_i_level(0),
+		rssi(0),
+		ber(0),
+		bto(0),
+		link_qual(0),
+		ms_rx_qual(0),
+		ms_c_value(0),
+		ms_sign_var(0)
 	{}
 #endif
 };

-- 
To view, visit https://gerrit.osmocom.org/1330
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I76a03c9f54be474ab9ece908ef782807d555c6ac
Gerrit-PatchSet: 2
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list