libosmocore[master]: fsm: explicitly log attempt to transition to same state

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 15 20:00:38 UTC 2016


Patch Set 1: Code-Review-1

I don't think this is the right approach.

The FSM can very well define that the current state is permitted as a next state of the FSM.  Also, in formal descriptions of FSMs in ITU/3GPP specs you often see states pointing back to themselves.

So I think when an osmo_fsm is defined, you as the author can decide if you want to permit the current state as a possible exit state or not.  If it is permitted, it is fine.  If not, then an error message and/or negative return code are appropriate.

-- 
To view, visit https://gerrit.osmocom.org/1434
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id4ba74ce54d10ebf42959d5f0d88ea5472cf95a3
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-HasComments: No



More information about the gerrit-log mailing list