[PATCH] libosmocore[master]: fsm: explicitly log removal from parent fsm

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Thu Dec 15 01:36:51 UTC 2016


Review at  https://gerrit.osmocom.org/1435

fsm: explicitly log removal from parent fsm

Since removing an FSM from its parent twice causes a segfault, it is very
interesting to see when that is attempted.

Removing could be made more robust, but logging is interesting for
investigating why an FSM is being removed twice in the first place (currently
the case in openbsc's vlr_lu_fsm).

Change-Id: Idec6b7aa5344f1e903c9d2aa2a3640cab0d70fb0
---
M src/fsm.c
1 file changed, 3 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmocore refs/changes/35/1435/1

diff --git a/src/fsm.c b/src/fsm.c
index d5c8f96..35831df 100644
--- a/src/fsm.c
+++ b/src/fsm.c
@@ -450,6 +450,9 @@
 	}
 
 	/* delete ourselves from the parent */
+	if (parent)
+		LOGPFSMSRC(fi, file, line, "Removing from parent %s\n",
+			   osmo_fsm_inst_name(parent));
 	llist_del(&fi->proc.child);
 
 	/* call destructor / clean-up function */

-- 
To view, visit https://gerrit.osmocom.org/1435
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idec6b7aa5344f1e903c9d2aa2a3640cab0d70fb0
Gerrit-PatchSet: 1
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>



More information about the gerrit-log mailing list