This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 1: (2 comments) https://gerrit.osmocom.org/#/c/1433/1/src/fsm.c File src/fsm.c: Line 460: #define ENUM_VAL_TO_VALUE_STRING(X) { X, #X } > This seems like generally useful macro. Perhaps move to utils? I think I use a similar one in gtphub somewhere, IIRC... do other reviewers think it's worth putting this in a public header? It would need an OSMO_ prefix then, right? Line 471: const char *osmo_fsm_term_cause_name(enum osmo_fsm_term_cause cause) > I thought the consensus was to use get_value_string directly instead of int I remember it so that we agreed to provide the value strings array publicly (this one is, it's declared in the .h) and to add a ... :) ... an inline function if we like. Gotcha, this isn't an inline function. Generally: we do have quite a number of shim functions to shortcut for get_value_string(long_array_name, enum_val), and I find them very useful, and I intend to add more as I go. I wish I could link to the comment directly, but see Harald's comment on PS3: https://gerrit.osmocom.org/267 ... I will change this into an inline function then. -- To view, visit https://gerrit.osmocom.org/1433 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf63d3cadb0d46bf454e3314ebb439240cafd834 Gerrit-PatchSet: 1 Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes