This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 12: Code-Review+2 (2 comments) https://gerrit.osmocom.org/#/c/1268/12/openbsc/contrib/twisted_ipa.py File openbsc/contrib/twisted_ipa.py: Line 255: def connectionMade(self): for python it's more typical to use underscored names: connection_made (like you do everywhere else) but that's coming from twisted, right? Line 265: class CtrlServer(CTRL): above it's 'CTRL', here it's 'CtrlServer'... Why not also 'Ctrl' and 'IpaServer' :) well, anyway. -- To view, visit https://gerrit.osmocom.org/1268 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I07559df420b7fe8418f3412f45acd9a375e43bc5 Gerrit-PatchSet: 12 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes