This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Max gerrit-no-reply at lists.osmocom.orgPatch Set 3: (2 comments) In general - please always provide feedback for the latest patchset to avoid confusion. https://gerrit.osmocom.org/#/c/1265/3/openbsc/contrib/ipa.py File openbsc/contrib/ipa.py: Line 27: class IPA(object): > our defines are always all-caps, but in function names we use all-lowercase This isn't a function, it's class. See Harald's comment above. Line 48: return 'UNKNOWN' > I think I have made my point very clear. Potential errors due to typos are Could you please provide an example code with such a error? I really don't want to overcomplicate code for the sake of avoiding potential error which might never happen. -- To view, visit https://gerrit.osmocom.org/1265 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e37ec143183e422c0b31af95d183bd84f0c328 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes