openbsc[master]: bsc_control.py: use ipa.py module

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 12 11:19:16 UTC 2016


Patch Set 8:

(1 comment)

I hope this is more clear

https://gerrit.osmocom.org/#/c/1266/8/openbsc/contrib/bsc_control.py
File openbsc/contrib/bsc_control.py:

Line 27:         do_set_get(sck, var, val)
> Erm, pardon but I don't get this at all. Could you please elaborate using m
It's just a style improvement suggestion.

Below you use do_set_get() to set a var and get the answer like this, twice, so you could do here:

a, _, _ = do_set_get(yada yada)
return a

and below just use a = set_var(yada yada) which is a nuance less dup and more importantly: far easier to read.

whoever doesn't care about the answer can just ignore set_var()'s return value.


-- 
To view, visit https://gerrit.osmocom.org/1266
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I25fd7cd4b42126354b72abd60a3837be5d13e159
Gerrit-PatchSet: 8
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list