This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 5: (2 comments) https://gerrit.osmocom.org/#/c/1262/5/openbsc/src/gprs/gprs_sgsn.c File openbsc/src/gprs/gprs_sgsn.c: Line 685: LOGMMCTXP(LOGL_INFO, mm, "SGSN intiated Deactivate PDP request\n"); here LOGMMCTXP makes sense, as it will print the identity of the mm-context (if any). However, you still need to print your %s / imsi, as you don't know at this line whether or not a mmctx was actually found. Line 703: LOGMMCTXP(LOGL_NOTICE, mm, "No MM context to deactivate\n"); > now you are loosing the IMSI information from the log line. Please think a to be more precise: here at this line, LOBMMCTXP makes no sense, but you can use it safely. however. as mm == NULL, you still need to have a %s for your IMSI. -- To view, visit https://gerrit.osmocom.org/1262 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia0a41aa2218ec2fda4ea17a37c8cc55cba63dd13 Gerrit-PatchSet: 5 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: pravin <pravin.manoharan at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes