This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 3: (3 comments) ok guys, let's wrap this up. * kwargs have no spaces * we keep uppercase class names * we use 'is None' or 'is not None' https://gerrit.osmocom.org/#/c/1265/3/openbsc/contrib/ipa.py File openbsc/contrib/ipa.py: Line 35: PROTO = dict(RSL = 0x00, CCM = 0xFE, SCCP = 0xFD, OML = 0xFF, OSMO = 0xEE, MGCP_OLD = 0xFC) > It looks like assignment because it is assignment. I don't get what's the c the official python style guide https://www.python.org/dev/peps/pep-0008/ addresses this in https://www.python.org/dev/peps/pep-0008/#other-recommendations an recommends not to use spaces for kwargs. Let's follow this recommendation and stop wasting time on debates. Line 236: if op != None: > if op is not None: @Max: see http://stackoverflow.com/questions/2209755/python-operation-vs-is-not so it seems indeed in this case "is not" is preferred in python Line 263: if k != var or (val != None and v != val): > 'val is not None' see above comment on 'is none' -- To view, visit https://gerrit.osmocom.org/1265 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41e37ec143183e422c0b31af95d183bd84f0c328 Gerrit-PatchSet: 3 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msuraev at sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-HasComments: Yes