[MERGED] openbsc[master]: gsm0408_test.c: Don't pass negative value to strerror()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Dec 9 16:26:09 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: gsm0408_test.c: Don't pass negative value to strerror()
......................................................................


gsm0408_test.c: Don't pass negative value to strerror()

Change-Id: I4fcf24ec1bc974a3189486d2372b9713d7fdab70
Fixes: Coverity CID 135192
---
M openbsc/tests/gsm0408/gsm0408_test.c
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved
  Jenkins Builder: Verified



diff --git a/openbsc/tests/gsm0408/gsm0408_test.c b/openbsc/tests/gsm0408/gsm0408_test.c
index 9e7babb..ae8cbdd 100644
--- a/openbsc/tests/gsm0408/gsm0408_test.c
+++ b/openbsc/tests/gsm0408/gsm0408_test.c
@@ -89,7 +89,7 @@
 {
 	int r = osmo_earfcn_add(e, earfcn, bw);
 	if (r)
-		printf("failed to add EARFCN %u: %s\n", earfcn, strerror(r));
+		printf("failed to add EARFCN %u: %s\n", earfcn, strerror(-r));
 	else
 		printf("added EARFCN %u - ", earfcn);
 }

-- 
To view, visit https://gerrit.osmocom.org/1327
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4fcf24ec1bc974a3189486d2372b9713d7fdab70
Gerrit-PatchSet: 5
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list