[PATCH] openbsc[master]: Use arch-independent type for SI length

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Max gerrit-no-reply at lists.osmocom.org
Wed Dec 7 18:20:45 UTC 2016


Review at  https://gerrit.osmocom.org/1371

Use arch-independent type for SI length

This is a troubleshooting fix in attempt to make hard-to-reproduce crash
during UARFCN encoding for SI2q into more predictable one.

Change-Id: I6e35d4c5e9822696e4b979e68a89bec6c99fec2f
---
M openbsc/src/libbsc/bsc_init.c
1 file changed, 6 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/71/1371/1

diff --git a/openbsc/src/libbsc/bsc_init.c b/openbsc/src/libbsc/bsc_init.c
index 9e913d6..077a23d 100644
--- a/openbsc/src/libbsc/bsc_init.c
+++ b/openbsc/src/libbsc/bsc_init.c
@@ -124,10 +124,13 @@
 /* set all system information types for a TRX */
 int gsm_bts_trx_set_system_infos(struct gsm_bts_trx *trx)
 {
-	int i, rc;
+	int rc;
 	struct gsm_bts *bts = trx->bts;
-	uint8_t gen_si[_MAX_SYSINFO_TYPE], n_si = 0, n;
-	int si_len[_MAX_SYSINFO_TYPE];
+	uint8_t gen_si[_MAX_SYSINFO_TYPE], n_si = 0, n, i,
+		/* SI length might be more than GSM_MACBLOCK_LEN (23 bytes) if we
+		   use SI2quater INDEX & COUNT and store them in-place but this
+		   isn't supported yet */
+		si_len[_MAX_SYSINFO_TYPE];
 
 	bts->si_common.cell_sel_par.ms_txpwr_max_ccch =
 			ms_pwr_ctl_lvl(bts->band, bts->ms_max_power);

-- 
To view, visit https://gerrit.osmocom.org/1371
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6e35d4c5e9822696e4b979e68a89bec6c99fec2f
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Max <msuraev at sysmocom.de>



More information about the gerrit-log mailing list