openbsc[master]: cosmetic: chan_alloc: use switch instead of if cascade

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Mon Dec 5 18:47:39 UTC 2016


Patch Set 1: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/1365/1/openbsc/src/libbsc/chan_alloc.c
File openbsc/src/libbsc/chan_alloc.c:

Line 153: 
are you sure we don't want a break here? yes, _most_ cases above have a return or continue, but three is the GSM_PCHAN_PDCH case which falls throug below. If that's intended, it is a semantic change compared to the previous 'if' clause, right?


-- 
To view, visit https://gerrit.osmocom.org/1365
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie5eb0fa859c4f225616095dc56d52ce0f2dc8bdc
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list