openbsc[master]: libbsc: add chreq type for CHREQ_T_PDCH_ONE_PHASE & CHREQ_T_...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Mon Dec 5 16:19:43 UTC 2016


Patch Set 1: Code-Review+1

(2 comments)

The build fails because it needs a commit in libosmocore: https://gerrit.osmocom.org/1361

Before merging to libosmocore, this patch should have +2 and follow right after, because otherwise the openbsc build would be broken.

I'd love to give my +2, but I don't really understand the changes in gsm_04_08_utils.c

https://gerrit.osmocom.org/#/c/1360/1/openbsc/src/libbsc/gsm_04_08_utils.c
File openbsc/src/libbsc/gsm_04_08_utils.c:

Line 78: 	{ 0x63, 0xff, CHREQ_T_RESERVED_SDCCH },
unrelated cosmetic change ... but small enough I guess


Line 99: 	{ 0x63, 0xff, CHREQ_T_RESERVED_SDCCH },
unrelated cosmetic change ... but small enough I guess


-- 
To view, visit https://gerrit.osmocom.org/1360
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie7f4ed000cf1b40d269873cf0ddf5ff9f5bbc18a
Gerrit-PatchSet: 1
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: lynxis lazus <lynxis at fe80.eu>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list