[PATCH] openbsc[master]: cfg_bts_si2quater_neigh_add(): Don't call strerror() on nega...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Fri Dec 2 11:58:10 UTC 2016


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1325

to look at the new patch set (#4).

cfg_bts_si2quater_neigh_add(): Don't call strerror() on negative value

Change-Id: I1300eede3f22df812b7e83902327ce4cde21aa35
Fixes: Coverity CID 135185
---
M openbsc/src/libbsc/bsc_vty.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/openbsc refs/changes/25/1325/4

diff --git a/openbsc/src/libbsc/bsc_vty.c b/openbsc/src/libbsc/bsc_vty.c
index 9ed19aa..0076591 100644
--- a/openbsc/src/libbsc/bsc_vty.c
+++ b/openbsc/src/libbsc/bsc_vty.c
@@ -2995,7 +2995,7 @@
 	r = osmo_earfcn_add(e, arfcn, meas);
 
 	if (r < 0) {
-		vty_out(vty, "Unable to add arfcn %u: %s%s", arfcn, strerror(r),
+		vty_out(vty, "Unable to add arfcn %u: %s%s", arfcn, strerror(-r),
 			VTY_NEWLINE);
 		return CMD_WARNING;
 	}

-- 
To view, visit https://gerrit.osmocom.org/1325
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1300eede3f22df812b7e83902327ce4cde21aa35
Gerrit-PatchSet: 4
Gerrit-Project: openbsc
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list