libosmocore[master]: gsm0480.c: code dup: have common msgb alloc functions

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 1 15:54:16 UTC 2016


Patch Set 2:

(1 comment)

https://gerrit.osmocom.org/#/c/1341/2/src/gsm/gsm0480.c
File src/gsm/gsm0480.c:

Line 37: 	return msgb_alloc_headroom(1024, 128, name);
I'm not quite sure if it is a good idea to hard-code message headroom sizes inside a library. The application might have a much better understanding of the kind of protocol stacking and headers it wishes to push in front of the message, particularly with L3 type messages where we have no idea of the amount of headers the various complex RAN protocols and their transport layers may add.


-- 
To view, visit https://gerrit.osmocom.org/1341
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I029551dd74410ad6f326ce52eb7a75d912d3b875
Gerrit-PatchSet: 2
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list