[MERGED] libosmo-netif[master]: stream-client: Check for osmo_fd_register() return value

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 1 14:54:51 UTC 2016


Harald Welte has submitted this change and it was merged.

Change subject: stream-client: Check for osmo_fd_register() return value
......................................................................


stream-client: Check for osmo_fd_register() return value

Change-Id: I1b5fa97d14e69ff502b6deba0fd898a01e53420f
Fixes: Coverity CID 57633
---
M examples/stream-client.c
1 file changed, 6 insertions(+), 1 deletion(-)

Approvals:
  Harald Welte: Looks good to me, approved; Verified



diff --git a/examples/stream-client.c b/examples/stream-client.c
index 112d78b..c54db02 100644
--- a/examples/stream-client.c
+++ b/examples/stream-client.c
@@ -93,6 +93,7 @@
 int main(void)
 {
 	struct osmo_fd *kbd_ofd;
+	int rc;
 
 	tall_test = talloc_named_const(NULL, 1, "osmo_stream_cli_test");
 
@@ -127,7 +128,11 @@
 	kbd_ofd->when = BSC_FD_READ;
 	kbd_ofd->data = conn;
 	kbd_ofd->cb = kbd_cb;
-	osmo_fd_register(kbd_ofd);
+	rc = osmo_fd_register(kbd_ofd);
+	if (rc < 0) {
+		LOGP(DSTREAMTEST, LOGL_ERROR, "FD Register\n");
+		exit(EXIT_FAILURE);
+	}
 
 	LOGP(DSTREAMTEST, LOGL_NOTICE, "Entering main loop\n");
 

-- 
To view, visit https://gerrit.osmocom.org/1332
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I1b5fa97d14e69ff502b6deba0fd898a01e53420f
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list