[PATCH] libosmo-netif[master]: rs232: Don't pass negative number to strerror()

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Thu Dec 1 14:53:07 UTC 2016


Hello Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/1335

to look at the new patch set (#2).

rs232: Don't pass negative number to strerror()

Change-Id: Ia777221cd0472cd1e7aa79e5146b07048a545dd8
Fixes: Coverity CID 57860
---
M src/rs232.c
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.osmocom.org:29418/libosmo-netif refs/changes/35/1335/2

diff --git a/src/rs232.c b/src/rs232.c
index 14b2d6e..798bf72 100644
--- a/src/rs232.c
+++ b/src/rs232.c
@@ -230,7 +230,7 @@
 	if (rc < 0) {
 		close(bfd->fd);
 		LOGP(DLINP, LOGL_ERROR, "rs232: could not register FD: %s\n",
-			strerror(rc));
+			strerror(-rc));
 		return rc;
 	}
 

-- 
To view, visit https://gerrit.osmocom.org/1335
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia777221cd0472cd1e7aa79e5146b07048a545dd8
Gerrit-PatchSet: 2
Gerrit-Project: libosmo-netif
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Jenkins Builder



More information about the gerrit-log mailing list