osmo-pcu[master]: EGPRS: EPDAN decoding: add test case to show no ack_nack len...

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Neels Hofmeyr gerrit-no-reply at lists.osmocom.org
Wed Aug 31 09:26:21 UTC 2016


Patch Set 8:

(2 comments)

https://gerrit.osmocom.org/#/c/765/8/tests/rlcmac/RLCMACTest.cpp
File tests/rlcmac/RLCMACTest.cpp:

Line 224: 	memset(urbb->URBB, -1, sizeof(urbb->URBB));
since you are now setting the memory to non-random values...


Line 233: 	"7f ff ff ee 00 00 00 00 00 00 00 00 00 "
... then also expect the exact bytes that are produced URBB.
Or am I still missing something here?


-- 
To view, visit https://gerrit.osmocom.org/765
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8da84794748f2e81722c3eca69b46ccc3a21552e
Gerrit-PatchSet: 8
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list