This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Neels Hofmeyr gerrit-no-reply at lists.osmocom.orgPatch Set 6: (1 comment) https://gerrit.osmocom.org/#/c/765/6/tests/rlcmac/RLCMACTest.cpp File tests/rlcmac/RLCMACTest.cpp: Line 231: OSMO_ASSERT(strcmp(osmo_hexdump(urbb->URBB, 13), > Hi Neels, Hmm, thinking again, if the random bits happen to be all zero by random, then this test would fail; or could randomly succeed, after we fixed it and when we've introduced a regression some time in the future. We should initialize the unwritten bytes to known values so that the result is deterministic: do a memset(urbb->URBB, -1, sizeof(urbb->URBB)); before calling decode_gsm_rlcmac_uplink()? Please try that. -- To view, visit https://gerrit.osmocom.org/765 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8da84794748f2e81722c3eca69b46ccc3a21552e Gerrit-PatchSet: 6 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Holger Freyther <holger at freyther.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-HasComments: Yes