osmo-pcu[master]: EGPRS: Add EPDAN CRBB Tree based decoding

[pravin]

Patch Set 22:

(9 comments)

https://gerrit.osmocom.org/#/c/416/21//COMMIT_MSG
Commit Message:

Line 7: EGPRS: Add EPDAN CRBB Tree based decoding
> "EGPRS: Add EPDAN CRBB Tree based decoding" would be more better.
Done


https://gerrit.osmocom.org/#/c/416/21/src/egprs_rlc_compression.cpp
File src/egprs_rlc_compression.cpp:

Line 1: /* egprs_rlc_compression.h
> Logs are missing from whole file. Can we have a debug logs at least at debu
Done


https://gerrit.osmocom.org/#/c/416/21/src/egprs_rlc_compression.h
File src/egprs_rlc_compression.h:

Line 17: int decompress_crbb(int8_t compress_bmap_len, uint8_t clr_code_bit,
> can we move it to .cpp/.c file?
Done


Line 18: 			const uint8_t *orig_buf, bitvec *dest);
> can we move it to .cpp/.c file?
Done


Line 26: 
> Can you use scope as private here?
Done


Line 38: 
> Keep Public first and then private. I have noticed in many .h file .
Done


https://gerrit.osmocom.org/#/c/416/21/tests/bitcomp/BitcompTest.cpp
File tests/bitcomp/BitcompTest.cpp:

Line 26: 	uint8_t crbb_data[MAX_CRBB_LEN]; /* compressed data */
> check for extra space
Done


Line 216: 	tall_pcu_ctx = talloc_named_const(NULL, 1, "moiji-mobile bitcompTest context");
> change TbfTest context
Done


Line 226: }
> can you leave a empty line here?
Done


-- 
To view, visit https://gerrit.osmocom.org/416
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieae1992ed4b02bb1e09eec2d3de1a030eabd16ce
Gerrit-PatchSet: 22
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: pravin <pravin.manoharan at radisys.com>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Max <msuraev at sysmocom.de>
Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de>
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: pravin <pravin.manoharan at radisys.com>
Gerrit-HasComments: Yes