This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
arvind.sirsikar gerrit-no-reply at lists.osmocom.orgHello Jenkins Builder, I'd like you to reexamine a change. Please visit https://gerrit.osmocom.org/765 to look at the new patch set (#5). EGPRS: EPDAN decoding: add test case to show no ack_nack len issue This patch adds a test case itest_epdan_noack_nack_len_issue which expects a current bug with EGPRS EPDAN decoding Ack/Nack dissector length is not received. The test's expectation is corrected along with the bug fix in a subsequent commit Related: OS#1805 Change-Id: I8da84794748f2e81722c3eca69b46ccc3a21552e --- M tests/rlcmac/RLCMACTest.cpp M tests/tbf/TbfTest.cpp 2 files changed, 24 insertions(+), 2 deletions(-) git pull ssh://gerrit.osmocom.org:29418/osmo-pcu refs/changes/65/765/5 diff --git a/tests/rlcmac/RLCMACTest.cpp b/tests/rlcmac/RLCMACTest.cpp index 466b89e..4f74ea4 100644 --- a/tests/rlcmac/RLCMACTest.cpp +++ b/tests/rlcmac/RLCMACTest.cpp @@ -30,6 +30,7 @@ #include "pcu_vty.h" #include <osmocom/vty/telnet_interface.h> #include <osmocom/vty/logging.h> +#include <osmocom/core/utils.h> #include <osmocom/core/application.h> } using namespace std; @@ -211,6 +212,27 @@ bitvec_free(resultVector); } +void test_epdan_no_ack_nack_len() +{ + bitvec *vector = bitvec_alloc(23); + + bitvec_unhex(vector, "40200bffd161003e0e519ffffffb800000000000000000"); + RlcMacUplink_t data; + + decode_gsm_rlcmac_uplink(vector, &data); + + EGPRS_AckNack_Desc_t *urbb = + &data.u.Egprs_Packet_Downlink_Ack_Nack.EGPRS_AckNack.Desc; + /* + * TODO: URBB len is decoded as 102. so there is total 12 bytes and + * 6 bits in the 13th byte. in 13th byte we expect value + * as 0x00. But we see some incorrect value + */ + OSMO_ASSERT(strcmp(osmo_hexdump(urbb->URBB, 13), + "7f ff ff ee 00 00 00 00 00 00 00 00 00 " + )); +} + int main(int argc, char *argv[]) { osmo_init_logging(&gprs_log_info); @@ -218,5 +240,5 @@ //printSizeofRLCMAC(); testRlcMacDownlink(); testRlcMacUplink(); - + test_epdan_no_ack_nack_len(); } diff --git a/tests/tbf/TbfTest.cpp b/tests/tbf/TbfTest.cpp index 2feb9c3..a4de6c9 100644 --- a/tests/tbf/TbfTest.cpp +++ b/tests/tbf/TbfTest.cpp @@ -646,7 +646,7 @@ * simulate RACH, this sends an Immediate * Assignment Uplink on the AGCH */ - the_bts->rcv_rach(0x73, rach_fn, qta); + the_bts->rcv_rach(0x73, rach_fn, qta, 0, GSM_L1_BURST_TYPE_ACCESS_0); /* get next free TFI */ tfi = the_bts->tfi_find_free(GPRS_RLCMAC_UL_TBF, &trx_no, -1); -- To view, visit https://gerrit.osmocom.org/765 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: newpatchset Gerrit-Change-Id: I8da84794748f2e81722c3eca69b46ccc3a21552e Gerrit-PatchSet: 5 Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Owner: arvind.sirsikar <arvind.sirsikar at radisys.com> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>