osmo-pcu[master]: Handle EGPRS 11 bit RACH in osmo-pcu

This is merely a historical archive of years 2008-2021, before the migration to mailman3.

A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.

Harald Welte gerrit-no-reply at lists.osmocom.org
Sat Aug 27 04:52:32 UTC 2016


Patch Set 4: Code-Review-1

(1 comment)

https://gerrit.osmocom.org/#/c/430/4/src/bts.h
File src/bts.h:

Line 290: 		uint8_t is_11bit, uint16_t*, uint16_t*);
why are there un-named / anonymous arguments to this function? Is there a specific reason for this?  Have you seen this pattern used in any other part of the code?  If so, please point it out so we can fix that.  If not, then please always align with the existing coding style, thanks.


-- 
To view, visit https://gerrit.osmocom.org/430
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I61d74a32f7764644ed86f7fdf97fa3c2f61503f7
Gerrit-PatchSet: 4
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Owner: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org>
Gerrit-Reviewer: Holger Freyther <holger at freyther.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: arvind.sirsikar <arvind.sirsikar at radisys.com>
Gerrit-Reviewer: bhargava_abhyankar <Bhargava.Abhyankar at radisys.com>
Gerrit-HasComments: Yes



More information about the gerrit-log mailing list