This is merely a historical archive of years 2008-2021, before the migration to mailman3.
A maintained and still updated list archive can be found at https://lists.osmocom.org/hyperkitty/list/gerrit-log@lists.osmocom.org/.
Harald Welte gerrit-no-reply at lists.osmocom.orgPatch Set 1: Code-Review-1 (2 comments) https://gerrit.osmocom.org/#/c/736/1/openbsc/include/openbsc/gsm_04_08_gprs.h File openbsc/include/openbsc/gsm_04_08_gprs.h: Line 5: /* TODO: Move this to osmocom/gsm/protocol/gsm_04_08_gprs.h ? */ please let's move it into libosmocore, this clearly doens't belong to the openbsc repo. Whether or not it should use a new header file (gsm_04_08_gprs.h instead of gsm_04_08.h), I'm not entirely sure. https://gerrit.osmocom.org/#/c/736/1/openbsc/src/gprs/gsm_04_08_gprs.c File openbsc/src/gprs/gsm_04_08_gprs.c: Line 29: { GPRS_SERVICE_T_SIGNALLING, "signalling" }, this value_string should also go to libosmocore, rather libosmogsm, like the header file. -- To view, visit https://gerrit.osmocom.org/736 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf9316f07d21280b6e090d65892c338f9555313a Gerrit-PatchSet: 1 Gerrit-Project: openbsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofmeyr at sysmocom.de> Gerrit-Reviewer: Harald Welte <laforge at gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-HasComments: Yes